Nir Soffer has posted comments on this change.

Change subject: storage: Introduction to imagetickets.py
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/50014/10/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 8421: # @timeout:   Timeout in seconds for the ticket to expire
Line 8422: #
Line 8423: # @ops:       operations list to be applied on the image
Line 8424: #
Line 8425: # @size:      block size of each transferred chunk
> Current daemon code assume that offset is always 0, and validate size with 
We agreed on keeping size, but the value must be the size of the image. Attempt 
to read or write must be withing the range 0 - (size - 1)

For example, writing 1000 bytes will write byte 0 to byte 999.
Line 8426: #
Line 8427: # @path:      an image path
Line 8428: #
Line 8429: # Since: 4.18.0


-- 
To view, visit https://gerrit.ovirt.org/50014
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b9ded4bde73b1ab504cae50d2cea726d4f77e51
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Amit Aviram <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to