Edward Haas has posted comments on this change. Change subject: net: Enable VDSM to perform migration over IPv6 ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/51933/3/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 127: def _createClient(self, port): Line 128: sslctx = sslutils.create_ssl_context() Line 129: Line 130: def is_ipv6_address(a): Line 131: return (':' in a) and a.startswith('[') and a.endswith(']') > I don't mind this inner function here, but are you sure there is not someth There is, but in the test code: _assertValidAddress I think we should have an ip tooling and use something like: ip.is_ipv6_address(addr) Not sure if all will agree and it is for future patches. Line 132: Line 133: if is_ipv6_address(self.remoteHost): Line 134: host = self.remoteHost[1:-1] Line 135: else: -- To view, visit https://gerrit.ovirt.org/51933 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id12e6df9004737ea6eec450d2e07cbb10aaa104a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
