Francesco Romani has posted comments on this change. Change subject: virt: stats: make compute_latency more robust ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/50593/8/vdsm/virt/vmstats.py File vdsm/virt/vmstats.py: Line 344: def add_latency(name, mode): Line 345: try: Line 346: stats[name] = str(compute_latency(mode)) Line 347: except KeyError: Line 348: pass > Same as previous patch, but here we see that we have a common pattern - we there are too many variables in play to construct the key. I don't think a common helper would really help here. Line 349: Line 350: add_latency('readLatency', 'rd') Line 351: add_latency('writeLatency', 'wr') Line 352: add_latency('flushLatency', 'fl') -- To view, visit https://gerrit.ovirt.org/50593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4670309d48bd65a3afaba8124407598b76d808d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
