Ryan Harper has posted comments on this change. Change subject: Avoid race condition with vdsm-reg during firstboot ......................................................................
Patch Set 1: I would prefer that you didn't submit this Moving my objection to disabling the service to this patch. Unless vdsm-reg service is needed during the install we should keep vdsm-reg disabled by default and only enable it after successful install so it can run after a reboot. This avoids the race and saves cputime and memory (why run a service if it isn't needed?) -- To view, visit http://gerrit.ovirt.org/8200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a215bbe6c467d10cf414b09cdaee5340092198e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fernando Granha Jeronimo <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Michael Burns <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
