Zhou Zheng Sheng has posted comments on this change. Change subject: dump the core of a domain ......................................................................
Patch Set 4: (2 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2012-08-07 17:04:58 +0800 Line 4: Commit: ShaoHe Feng <[email protected]> Line 5: CommitDate: 2012-09-24 19:58:06 +0800 Line 6: Line 7: dump the core of a domain Is it better to use VM instead of domain? Because in VDSM we have storage domains, this message will make other people confused. Line 8: Line 9: libvirt support an API to dump the core of a domain on a given file for Line 10: analysis when guest OS crash. Line 11: .................................................... File vdsm/vm.py Line 303: Line 304: def _finishSuccessfully(self): Line 305: self.status = {'status': {'code': 0, 'message': Line 306: 'Dump finished sucessfully'}, Line 307: 'progress': "done"} self.status can be written from the worker thread, and can be read from the main thread. Could race condition happen on "self.status"? It seems the race condition is not a big problem here, it just affects the accuracy of the status report. And Status transitions here is only to one direction, so if the client does not get the latest status, it can get a accurate one in the next call. Line 308: Line 309: def run(self): Line 310: Line 311: def reportError(key='coreDumpErr', msg=None): -- To view, visit http://gerrit.ovirt.org/7329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
