Edward Haas has posted comments on this change. Change subject: net: Refactor _canonize_networks for readablity ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/52478/2/lib/vdsm/network/api.py File lib/vdsm/network/api.py: Line 972: normalize.norm_mtu() Line 973: normalize.norm_vlan() Line 974: Line 975: Line 976: class _Normalize(object): > as you probably have guessed, I don't think this is more readable that call It's not more readable in this case, it's just cleaner IMO. Grouping the methods, avoiding passing the same input over are good enough reasons. Not sure why you dislike short-lived objects, many times they add order. What exactly are the cons? Changing to 'canonize' in the meantime. Line 977: def __init__(self, data): Line 978: self.data = data Line 979: Line 980: def norm_remove(self): -- To view, visit https://gerrit.ovirt.org/52478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I296cd3f1dacf69fc1968fe0ca74b49e40ed72a9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
