Yaniv Bronhaim has posted comments on this change. Change subject: terminating tests - verify process death ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/52362/5/tests/utilsTests.py File tests/utilsTests.py: Line 123: try: Line 124: with utils.terminating(proc): Line 125: self.assertTrue(os.path.exists(proc_path)) Line 126: except FakeKillError: Line 127: exception_raise = True this fails :) terminating doesn't raise the kill exception (or poll exception) at all .. should I do that? I only add the pid to zombiereaper Line 128: Line 129: if not exception_raise: Line 130: self.fail("Exception was not raised") Line 131: self.assertTrue(proc.pid in self.reaped) -- To view, visit https://gerrit.ovirt.org/52362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1600a298b3faaffe3cc72b4eb62201370bf03c7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
