Adam Litke has posted comments on this change. Change subject: schema: make ConnectionRefArgs definition agree with the code ......................................................................
Patch Set 3: I would prefer that you didn't submit this 'type' is not a valid identifier for a gobject-based library because it causes naming conflicts with the GType system. In order to solve the problem you have identified, we must convert the 'connType' member to 'type' at the last minute just before passing the args into vdsm. This will be done by some translation code inside Bridge.py. -- To view, visit http://gerrit.ovirt.org/8020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb209b577c6736b3b50cf400996b0999a60a8776 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
