Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: stats: make _disk_iops_bytes more robust
......................................................................


virt: stats: make _disk_iops_bytes more robust

Make reporting of iops and bytes more robust and less noisy
when some fields are missing from bulk stats.
This can happen, so we must handle this case silently.

Since this patch fixes the last possible source of
KeyErrors, is now possible to unbreak existing related
vmStatsTests.

Backport-To: 3.6
Change-Id: I341779e2629a1122e4c0fa55206ad404f3eb2f48
Bug-Url: https://bugzilla.redhat.com/1281337
Signed-off-by: Francesco Romani <from...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/50594
Continuous-Integration: Jenkins CI
Reviewed-by: Martin Polednik <mpoled...@redhat.com>
Reviewed-by: Nir Soffer <nsof...@redhat.com>
---
M tests/vmStatsTests.py
M vdsm/virt/vmstats.py
2 files changed, 14 insertions(+), 10 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/50594
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I341779e2629a1122e4c0fa55206ad404f3eb2f48
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to