Nir Soffer has posted comments on this change. Change subject: Introducing context manager to terminate async processes on internal fail ......................................................................
Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/51407/14/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 780: if proc.poll() is None: Line 781: zombiereaper.autoReapPID(proc.pid) Line 782: except Exception: Line 783: logging.exception('Failed to kill process %d' % proc.pid) Line 784: zombiereaper.autoReapPID(proc.pid) > we should not auto-rip proc.pid if we are not sure that proc.poll() is None Fine with me, lets remove reaping here. Line 785: Line 786: Line 787: def get_selinux_enforce_mode(): Line 788: """ -- To view, visit https://gerrit.ovirt.org/51407 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I003cce39d62dba5644937fafaf2c6e24c526c075 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
