Piotr Kliczewski has posted comments on this change. Change subject: Move hooking.py to vdsm/lib ......................................................................
Patch Set 1: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/52647/1/vdsm_hooks/ovs/ovs_after_get_caps.py File vdsm_hooks/ovs/ovs_after_get_caps.py: Line 27: execCmd same comment as for ovs_before_network_setup module https://gerrit.ovirt.org/#/c/52647/1/vdsm_hooks/ovs/ovs_before_network_setup.py File vdsm_hooks/ovs/ovs_before_network_setup.py: Line 40: execCmd why not to call hooking.execCmd and remove this import? https://gerrit.ovirt.org/#/c/52647/1/vdsm_hooks/ovs/ovs_utils.py File vdsm_hooks/ovs/ovs_utils.py: Line 24: execCmd the same comment as for ovs_before_network_setup module -- To view, visit https://gerrit.ovirt.org/52647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic03bd214cafc93e7c38de7d4aff6ef98753c55f9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
