Edward Haas has posted comments on this change.

Change subject: ipv6: ifcfg: explicitly disable dhcpv6
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

We should also add a proper functional test to catch this scenario:
IPv4 DHCP enabled, IPv6 DHCP disabled.
And vice versa.

https://gerrit.ovirt.org/#/c/52759/1/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:

Line 539: ipv6autoconf
Should be dhcpv6


-- 
To view, visit https://gerrit.ovirt.org/52759
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfca4008f19e1f369b67da6ec958576278d4fd50
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to