Francesco Romani has posted comments on this change. Change subject: virt: move handling of recovery file in a class ......................................................................
Patch Set 6: (5 comments) https://gerrit.ovirt.org/#/c/51388/6/vdsm/virt/recovery.py File vdsm/virt/recovery.py: Line 61: return [vm for vm, xmlDom in _listDomains() Line 62: if vmxml.has_channel(xmlDom, vmchannels.DEVICE_NAME)] Line 63: Line 64: Line 65: class VmState(object): > s/VmState/File/g Done Line 66: """ Line 67: "pickle" for vm state. Line 68: """ Line 69: Line 69: Line 70: _log = logging.getLogger("virt.recovery.vmstate") Line 71: Line 72: def __init__(self, vmid): Line 73: self._vmid = vmid > unused Done Line 74: self._recovery_file = os.path.join( Line 75: constants.P_VDSM_RUN, Line 76: '%s.recovery' % vmid Line 77: ) Line 70: _log = logging.getLogger("virt.recovery.vmstate") Line 71: Line 72: def __init__(self, vmid): Line 73: self._vmid = vmid Line 74: self._recovery_file = os.path.join( > self._path Done Line 75: constants.P_VDSM_RUN, Line 76: '%s.recovery' % vmid Line 77: ) Line 78: self._lock = threading.Lock() Line 88: is not > placing the positive branch first is easier to understand. Done https://gerrit.ovirt.org/#/c/51388/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 265: self.id = self.conf['vmId'] > why are we initializing self.id so late? No clue :) Will fix in a different patch. -- To view, visit https://gerrit.ovirt.org/51388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6866eb2c3c9d5784c2054c860cbf0977e8e58031 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
