Francesco Romani has posted comments on this change.

Change subject: WIP DONTMERGE: migrationLimit retry
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/52799/1/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 293:                 'mode': self._mode,
Line 294:                 'method': METHOD_ONLINE,
Line 295:                 'dstparams': self._dstparams,
Line 296:                 'dstqemu': self._dstqemu,
Line 297:             }
> this was just moved here from the with/try nested blocks. It was inside for
maybe move to a method?
Line 298: 
Line 299:             while not self._completed:
Line 300:                 try:
Line 301:                     with SourceThread._ongoingMigrations:


-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to