ShaoHe Feng has posted comments on this change.
Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
......................................................................
Patch Set 3:
yes, you are right.
since you have move the files from vdsm-gluster rpm to vdsm rpm, so there is
no need to check the modules of vdsm-gluster are available.
actually they must be available, if not, test should report error.
so you should remove the setUp function and the exception when you import the
gluster modules.
--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I079facc5d4fc7c3bfd8460731e6708fce242164e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
