Francesco Romani has uploaded a new change for review. Change subject: periodic: remove useless log ......................................................................
periodic: remove useless log Periodic sampling code used to log a warning when trying to sample a domain not connected. This also happens when the VM is a migration destination, and it is an expected condition. This made it evident that in such cases there there is no point in logging anything at all, this is an expected condition. In case of unexpected disconnections, we must learn this from elsewhere (e.g. libvirt callbacks), so this is the final push to remove this log entirely. Change-Id: I3aa03074dbf91dd1c88e5f3fca74c2a907627670 Related-To: https://bugzilla.redhat.com/1299480 Backport-To: 3.6 Signed-off-by: Francesco Romani <from...@redhat.com> --- M vdsm/virt/periodic.py 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/52895/1 diff --git a/vdsm/virt/periodic.py b/vdsm/virt/periodic.py index 2558292..cac6ef7 100644 --- a/vdsm/virt/periodic.py +++ b/vdsm/virt/periodic.py @@ -290,9 +290,9 @@ except virdomain.NotConnectedError: # race on startup: no worries, let's retry again next cycle. # race on shutdown: next cycle won't pick up this VM. - # both cases: let's reduce the log spam. - self._vm.log.warning('could not run on %s: domain not connected', - self._vm.id) + # migration destination: we know the domain is not connected. + # for all cases: let's reduce the log spam. + pass except libvirt.libvirtError as e: if e.get_error_code() in (libvirt.VIR_ERR_NO_DOMAIN, libvirt.VIR_ERR_OPERATION_UNSUPPORTED,): -- To view, visit https://gerrit.ovirt.org/52895 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3aa03074dbf91dd1c88e5f3fca74c2a907627670 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
