Edward Haas has posted comments on this change. Change subject: [wip] Dynamic load of supervdsm_api funcs ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/52875/3/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 152: is_module = re.compile(r"^[^_].*\.pyc?$").search : modules = set(os.path.splitext(name)[0] : for name in os.listdir(supervdsm_api.__path__[0]) : if is_module(name)) : for module in modules: : pkg = "%s.%s" % (supervdsm_api.__name__, module) : m = __import__(pkg, globals(), locals(), [module], level=0) : for func in dir(m): : if func.startswith('api_'): : # TODO: raise on duplications : self.api[func[4:]] = getattr(m, func) > It has functionality that has nothing to do with supervdsm, it just feels w What about the second part (splitting to functions)? -- To view, visit https://gerrit.ovirt.org/52875 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67a1c349c15a03ba54788ffafd0c5b9d30ff7037 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
