Francesco Romani has posted comments on this change. Change subject: Make VM._correctGraphicsConfiguration use DomainDescriptor ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/52823/1/vdsm/virt/domain_descriptor.py File vdsm/virt/domain_descriptor.py: Line 68: Line 69: def __init__(self, xmlStr): Line 70: super(DomainDescriptor, self).__init__(xmlStr) Line 71: self._xml = xmlStr Line 72: self._devices = super(DomainDescriptor, self).devices > There is no _devices in the parent class. As for `devices', the correspondi You are right, I missed the "just once" part. It could be worth to make the class names more explicit when this is un-drafted. Line 73: self._devices_hash = super(DomainDescriptor, self).devices_hash Line 74: Line 75: @property Line 76: def xml(self): -- To view, visit https://gerrit.ovirt.org/52823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9583d81d3d561d806499b55aa64f733437800c4b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
