Federico Simoncelli has uploaded a new change for review.

Change subject: build: improve the gitignore Makefile check
......................................................................

build: improve the gitignore Makefile check

Change-Id: Ifc2315d39fa975089f152757bedf88ec1607b921
Signed-off-by: Federico Simoncelli <[email protected]>
---
M Makefile.am
1 file changed, 5 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/8244/1

diff --git a/Makefile.am b/Makefile.am
index 54510a0..abaa4e8 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -119,15 +119,11 @@
                -name '*.py' -o -name '*.py.in'  | xargs $(PYFLAKES)
        $(PEP8) --exclude="$(PEP8_BLACKLIST)" --filename '*.py,*.py.in' \
                $(PEP8_WHITELIST)
-
-       [ -f .gitignore ] || exit 0;                                    \
-       gitignore=`mktemp`;                                             \
-       lsfiles=`mktemp`;                                               \
-       LC_ALL=C sort .gitignore > "$$gitignore";                       \
-       git ls-files '*.py.in' | sed 's/\.in$$//' |                     \
-       LC_ALL=C sort > "$$lsfiles";                                    \
-       LC_ALL=C comm -1 -3 "$$gitignore" "$$lsfiles" |                 \
-       grep . && exit 1 || exit 0
+       @for i in $$(git ls-files \*.py.in); do \
+         if ! grep -q $${i%%.in} .gitignore; then \
+           echo "Missing $${i%%.in} in .gitignore"; exit 1; \
+         fi; \
+       done;
 
 all-local: \
        vdsm.spec


--
To view, visit http://gerrit.ovirt.org/8244
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc2315d39fa975089f152757bedf88ec1607b921
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to