Alon Bar-Lev has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() call
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 1420:     RHEVM_CERT_FILE = "/ca.crt"
Line 1421:     rhevmCert = getRemoteFile(str(IP), str(port), RHEVM_CERT_FILE)
Line 1422:     if rhevmCert:
Line 1423:         nodeCleanup()
Line 1424:         dirName = os.path.dirname(CACERT)
So I don't really understand what is different in this regard. The only change 
I would still like to do is store temp file and then move to destination as 
procedure for updating files.
Line 1425:         if not os.path.exists(dirName):
Line 1426:             os.makedirs(dirName)
Line 1427:         crt = file(CACERT, "w+")
Line 1428:         try:


--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to