Dan Kenigsberg has posted comments on this change.
Change subject: Read 'source' of NIC interface only if exists
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 2488: alias =
x.getElementsByTagName('alias')[0].getAttribute('name')
Line 2489: model =
x.getElementsByTagName('model')[0].getAttribute('type')
Line 2490: source = x.getElementsByTagName('source')
Line 2491: if source:
Line 2492: bridge = source[0].getAttribute('bridge')
this won't help Yasny's hook
http://gerrit.ovirt.org/#/c/7547/5/vdsm_hooks/vmfex/before_vm_start.py line
#210 that sets a <source> that is not a bridge, but a network.
How about starting with
bridge = None
setting it according to the domxml, and reporting it only if not None?
Line 2493: # Get nic address
Line 2494: address = self._getUnderlyingDeviceAddress(x)
Line 2495: for nic in self._devices[vm.NIC_DEVICES]:
Line 2496: if nic.macAddr.lower() == mac.lower():
--
To view, visit http://gerrit.ovirt.org/8249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idec5aef35298d93fd35d4f4a1933809c32ecce16
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Itzik Brown <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
