Bala.FA has posted comments on this change.
Change subject: added glusterVolumeProfileInfo verb
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(3 inline comments)
....................................................
Commit Message
Line 7: added glusterVolumeProfileInfo verb
Line 8:
Line 9: Following is the output structure
Line 10:
Line 11: { 'statusCode' : CODE,
What does statusCode mean? Isn't it conflicting with verb 'status'?
Line 12: 'volumeName' : VOLUME-NAME,
Line 13: 'brickCount' : BRICK-COUNT,
Line 14: 'bricks' : {
Line 15: BRICK-NAME: {
Line 9: Following is the output structure
Line 10:
Line 11: { 'statusCode' : CODE,
Line 12: 'volumeName' : VOLUME-NAME,
Line 13: 'brickCount' : BRICK-COUNT,
No need of brickCount
Line 14: 'bricks' : {
Line 15: BRICK-NAME: {
Line 16: 'cumulativeStats': {
Line 17: 'blockStats': [
....................................................
File vdsm/gluster/cli.py
Line 819: return True
Line 820:
Line 821:
Line 822: @exportToSuperVdsm
Line 823: def volumeProfileInfo(volumeName):
Add docstring describing return structure
Line 824: command = _getGlusterVolCmd() + ["profile", volumeName, "info"]
Line 825: try:
Line 826: xmltree = _execGlusterXml(command)
Line 827: except ge.GlusterCmdFailedException, e:
--
To view, visit http://gerrit.ovirt.org/7436
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6a26fa7634b999cd70197c958fe86a6d9ed4a9c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
