Sagi Shnaidman has posted comments on this change. Change subject: Advertise aggregator ID in bonding interfaces ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/53100/6/lib/vdsm/netinfo/nics.py File lib/vdsm/netinfo/nics.py: Line 73: except IOError: Line 74: return 0 Line 75: Line 76: Line 77: def _get_aggregator_id(nic_name, bond=False): > My recommendation is to report this nic information through the bond slaves It's much more difficult to handle it there, we need to insert a new structure, because slaves now are reported as list, without any attributes with it. Let's discuss it tomorrow. Line 78: """Read ad_aggregator_id of NIC. If it's bond, read Line 79: ad_partner_mac as well. Line 80: """ Line 81: sys_nic_path = NET_CONFIG.format(nic=nic_name) https://gerrit.ovirt.org/#/c/53100/6/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 2827: Line 2828: @permutations([[{}], [{'options': 'mode=4 lacp_rate=1 miimon=100'}]]) Line 2829: @cleanupNet Line 2830: @ValidateRunningAsRoot Line 2831: def test_bond_mode4_caps_aggregator_id(self, mode4): > I mean, if you add this test and the new production code does not exist, it With mode4 it couldn't pass in any case, old code doesn't know to read agg_id. Anyway, I changed it to be more strict now. Line 2832: with dummyIf(3) as nics: Line 2833: bonding = {'nics': nics[:2]} Line 2834: bonding.update(mode4) Line 2835: status, msg = self.setupNetworks( -- To view, visit https://gerrit.ovirt.org/53100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85267967c9cb1b0a626d91cb1953361ed4de727a Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sagi Shnaidman <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Sagi Shnaidman <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
