Federico Simoncelli has posted comments on this change.
Change subject: [wip] volume: make volume._share idempotent
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/fileVolume.py
Line 237: ('metadata', self._getMetaVolumePath(),
Line 238: self._getMetaVolumePath(dstVolumePath),
True),
Line 239: ('lease', self._getLeaseVolumePath(),
Line 240: self._getLeaseVolumePath(dstVolumePath),
Line 241: sdCache.produce(self.sdUUID).hasVolumeLeases()),
What I don't like here is that when calling _share during upgrade the domain is
still < V3 and therefore the presence of the lease is not enforced. Anyway this
should be a minor issue.
Line 242: ]
Line 243:
Line 244: for itemName, srcPath, dstPath, itemRequired in itemsList:
Line 245: self.log.debug("Sharing %s %s to %s (required: %s)",
itemName,
--
To view, visit http://gerrit.ovirt.org/8270
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I237e4a8f094ba04dcd4ef7bff418e03f81162d8d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
