Francesco Romani has posted comments on this change. Change subject: virt: Fix of uninitialized variable access in Vm.setLinkAndNetwork() ......................................................................
Patch Set 2: Code-Review+2 Milan, I agree this fix falls into "trivial" category, so I'm ok with V+1 as-is. The fact that this didn't explode before gives weight to the theory that this is not easy to trigger. Of course in the long run (and in a different patch set) we should add tests to cover this flow. raising score since I was the one which introduced the bug, I'm eager to have it fixed :) -- To view, visit https://gerrit.ovirt.org/53061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04b44a1599593e825cc83f8df6edd4965ff43707 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
