Ayal Baron has posted comments on this change. Change subject: stats: move the lastCheck computation in getRepoStats ......................................................................
Patch Set 3: (2 inline comments) .................................................... Commit Message Line 6: Line 7: stats: move the lastCheck computation in getRepoStats Line 8: Line 9: Since getVdsStats relies on repoStats for the storage domain statistics Line 10: it makes sense to move the lastCheck computation in the latter one. s/in/into/? (and s/one//) Line 11: Moreover the repoStats call before this patch was returning the unix Line 12: timestamp for the lastCheck (wrong) instead of the elapsed time. Line 13: Line 14: Signed-off-by: Federico Simoncelli <[email protected]> Line 8: Line 9: Since getVdsStats relies on repoStats for the storage domain statistics Line 10: it makes sense to move the lastCheck computation in the latter one. Line 11: Moreover the repoStats call before this patch was returning the unix Line 12: timestamp for the lastCheck (wrong) instead of the elapsed time. This still seems odd to me. If engine does not expect the type of value currently returned, how is it that not all domains are constantly non-operational? Line 13: Line 14: Signed-off-by: Federico Simoncelli <[email protected]> -- To view, visit http://gerrit.ovirt.org/7993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58de0c517bc6940f21c7f6506854c9d9735e964b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
