Eduardo has posted comments on this change. Change subject: prepare volume instead of prepare blockSD ......................................................................
Patch Set 3: I would prefer that you didn't submit this (4 inline comments) .................................................... Commit Message Line 7: prepare volume instead of prepare blockSD Line 8: Line 9: Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=851837 Line 10: Line 11: change the call of activateVolume to llprepare volume, and outdated reference to llprepare. Line 12: teardown instead of deactiveVolume, which sperates lv Line 13: syscall operation to only verifies that the lv is in used as Line 14: part of the volume. If the sd is in use by the checked volume, Line 15: we want to keep ref counter to sign this volume, and when we Line 14: part of the volume. If the sd is in use by the checked volume, Line 15: we want to keep ref counter to sign this volume, and when we Line 16: teardown it, we verify that there are no references to the same Line 17: sd before deactivate it. Line 18: Please clarify the idea. Line 19: Change-Id: I25b9c260a7de5f883420a5322f90195b3379e80e .................................................... File vdsm/storage/image.py Line 382: if tmplVolume: Line 383: chain.insert(0, tmplVolume) Line 384: Line 385: # Activating the volumes Line 386: sdCache.produce(sdUUID).prepare() SD.prepare() function does not exist! Line 387: Line 388: return chain Line 389: Line 390: def teardown(self, sdUUID, imgUUID, volUUID=None): Line 391: chain = self.getChain(sdUUID, imgUUID, volUUID) Line 392: Line 393: # Deactivating the volumes Line 394: # Do not deactivate the template yet (might be in use by an other vm) Line 395: sdCache.produce(sdUUID).teardown(sdUUID, volUUIDs=[vol.volUUID for vol in chain]) SD.teardown() function does not exist! Line 396: Line 397: def __templateRelink(self, destDom, imgUUID, volUUID): Line 398: """ Line 399: Relink all hardlinks of the template 'volUUID' in all VMs based on it. -- To view, visit http://gerrit.ovirt.org/8050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25b9c260a7de5f883420a5322f90195b3379e80e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
