Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: added decorator to host uuid function ......................................................................
Patch Set 1: (1 comment) Can you push the patch again without the Draft? https://gerrit.ovirt.org/#/c/53499/1/lib/vdsm/host.py File lib/vdsm/host.py: Line 21: Line 22: from vdsm.utils import memoized Line 23: Line 24: import os Line 25: import logging we keep the imports in order such that buildin imports before project internals - so can you please move the import under the logging ? Line 26: from .commands import execCmd Line 27: from . import constants Line 28: from . import cpuarch Line 29: -- To view, visit https://gerrit.ovirt.org/53499 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42b725075a14bb090e9dd0aa429fffe537ccfed9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
