Dan Kenigsberg has posted comments on this change.
Change subject: Fix some pep8 errors
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Zhou, misc.py is already in the whitelist.
....................................................
File vdsm/storage/misc.py
Line 643: currentThread = threading.currentThread()
Line 644:
Line 645: # Handle reacquiring lock in the same thread
Line 646: if currentThread in self._holdingThreads:
Line 647: if not self._currentState and exclusive:
as noted earlier by ShaoHe Feng, this is a logic change, not only a stylistic
one.
even if you really want to mix the two in the same patch, his comment deserve
an explanation.
Line 648: raise RuntimeError("Lock promotion is forbidden.")
Line 649:
Line 650: self._holdingThreads[currentThread] += 1
Line 651: return
--
To view, visit http://gerrit.ovirt.org/8237
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I417f646b8fc1f242f3d5c91fdf0d7e79600552e9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
