Francesco Romani has posted comments on this change. Change subject: migration: added support for convergence schedule ......................................................................
Patch Set 14: Code-Review-1 (1 comment) -1 for visibility. We need better schema/documentation, codewise still OK. https://gerrit.ovirt.org/#/c/46940/14//COMMIT_MSG Commit Message: Line 11: The convergence schedule contains of 2 parts: : - initialization: will be evaluated before the migration starts. It is a list : of tuples: : - action: one of : - setDowntime: sets the 'migrateSetMaxDowntime' of the migrating VM : - abort: aborts the migration : - params: parameters of the action (e.g. the setDowntime takes one parameter, : the actual downtime). : - convergence: will be evaluated during migration as a part of the monitoring : thread on each monitoring cycle. It is a list of tuples: : - stalling limit: if the VM is stalling longer than this limit, execute the : action with its params. : - action with params: the actual action with params which has to be executed : if the VM is stalling longer than the stalling limit. The value is the same : as for the initialization, namely: : - action: one of : - setDowntime: sets the 'migrateSetMaxDowntime' of the migrating VM : - abort: aborts the migration : - params: parameters of the action (e.g. the setDowntime takes one parameter, : the actual downtime). after another mtg, turns out we should add better documentation and use more schema types whatever possible, to make sure the convergenceSchedule we pass is less opaque and verifiable once we have Piotr's schema converter. Otherwise fine. -- To view, visit https://gerrit.ovirt.org/46940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
