Marek Libra has posted comments on this change. Change subject: jsonrpcvdscli: Arrays can be returned from client call ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/53452/1/lib/vdsm/jsonrpcvdscli.py File lib/vdsm/jsonrpcvdscli.py: Line 112: return response.success_raw(resp.result) Line 113: Line 114: if resp.result and resp.result is not True: Line 115: # None is translated to True inside our JSONRPC implementation Line 116: if isinstance(resp.result, dict): > please check for list and go with dict as default (else). With current code Done Line 117: return response.success(**resp.result) Line 118: else: Line 119: return response.success(items=resp.result) Line 120: -- To view, visit https://gerrit.ovirt.org/53452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff22f6d75e9ff3400d1a2a2f64de5c121192e2f2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marek Libra <mli...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mli...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches