Edward Haas has posted comments on this change. Change subject: net: Adding network api module to supervdsm ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/53496/6/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 459 Line 460 Line 461 Line 462 Line 463 > at least copy the well written comments to lib/vdsm/tc/__init__.py - too ba But I did moved the comments there. Regarding the api.. It is preferred not to have implementation details in the api, 'hiding' it. At least this is how I see it. -- To view, visit https://gerrit.ovirt.org/53496 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75197754b9c64ccc1a58632802ba0cc8d99c9eb9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
