Tomas Jelinek has posted comments on this change. Change subject: migration: added support for setting the convergenceSchedule ......................................................................
Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/47734/15/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 7887: #optional actions to perform when stalling : # The format is a JSON, which consists of two lists: : # [init, convergence] : # The init is a list of: [action, [params]] : # The convergence is a list of: : # [stalling limit, [action, [params]]] > Interesting, How it failed? badly: jsonrpc.Executor/1::ERROR::2016-02-17 09:30:59,959::__init__::532::jsonrpc.JsonRpcServer::(_serveRequest) Internal server error Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/yajsonrpc/__init__.py", line 527, in _serveRequest res = method(**params) File "/usr/share/vdsm/rpc/Bridge.py", line 277, in _dynamicMethod result = fn(*methodArgs) File "/usr/share/vdsm/API.py", line 559, in migrate return v.migrate(params) File "/usr/share/vdsm/virt/vm.py", line 1512, in migrate self, **params) File "/usr/share/vdsm/virt/migration.py", line 136, in __init__ for (act, params) in schedule[0] ValueError: need more than 1 value to unpack e.g. the schedule which was taken from kwargs.get('convergenceSchedule') was not actually a json. Maybe the reason is that it was 'alias' and not 'type'? -- To view, visit https://gerrit.ovirt.org/47734 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09818e6f3283880edb704cb77c1f716392b11abe Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
