Francesco Romani has submitted this change and it was merged. Change subject: exception: Make VdsmException reusable ......................................................................
exception: Make VdsmException reusable VdsmException was initializing code and message to default values if called without arguments. This make is useless as as base class for more specific exceptions, defining real code and message. GlusterException, the only exception inheriting from VdsmException, avoided this issue by overriding __init__. Required-For: https://bugzilla.redhat.com/1295778 Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/48875 Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Piotr Kliczewski <[email protected]> Continuous-Integration: Jenkins CI Reviewed-on: https://gerrit.ovirt.org/52982 Tested-by: Piotr Kliczewski <[email protected]> Reviewed-by: Yaniv Bronhaim <[email protected]> Reviewed-on: https://gerrit.ovirt.org/53698 Continuous-Integration: Francesco Romani <[email protected]> --- M lib/vdsm/exception.py M tests/Makefile.am A tests/exception_test.py 3 files changed, 35 insertions(+), 4 deletions(-) Approvals: Piotr Kliczewski: Verified Francesco Romani: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6.3 Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
