Doron Fediuck has posted comments on this change. Change subject: BZ#833425 Change source of CPU sockets/cores to libvirt ......................................................................
Patch Set 15: I would prefer that you didn't submit this Amador, looking at http://libvirt.org/formatdomain.html#elementsCPU it seems that either it's not up-to-date or there's are missing parts. Your implementation is looking for 'cells' while the documentation handles 'cell'. Also it refers to guest topology and not host topology, which needs to be checked. Last thing, AFAIR NUMA is optional. This means your calculations may go wrong if no NUMA available. Can you please validate it? -- To view, visit http://gerrit.ovirt.org/5481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1619e3d9e042bc801c988f099d3b84922f4e03d3 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
