Dan Kenigsberg has posted comments on this change. Change subject: prepareForShutdown is not called when connection to libvirt is broken. ......................................................................
Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) .................................................... Commit Message Line 5: CommitDate: 2012-10-01 14:08:13 +0200 Line 6: Line 7: prepareForShutdown is not called when connection to libvirt is broken. Line 8: Line 9: add few more error codes taken from libvirt's virsh code. In future we should replace all this with a callback function they are adding in (not in RHEL 6.3) Actually, in the future, I think we'd better avoid restarting vdsm, and re-populate object from the new libvirt instance. Please break this long line Line 10: Line 11: Change-Id: Ic1d9a2cd9bfd7da9118d643d0e50106e5e759590 Line 12: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=852956 -- To view, visit http://gerrit.ovirt.org/8283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1d9a2cd9bfd7da9118d643d0e50106e5e759590 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
