Dan Kenigsberg has submitted this change and it was merged. Change subject: bootstrap: remove MAC address from vds unique id ......................................................................
bootstrap: remove MAC address from vds unique id CURRENT IMPLEMENTATION vds unique id is at format: @BIOS UUID@_@Low(MAC)@ If BIOS UUID was not available either empty or "Not" were used. PROBLEMS IN CURRENT IMPLEMENTATION BIOS UUID may be missing or duplicate. MAC may change either because of bonding (resolved) or because of physical adapter change. ASSUMPTION Hosts with no BIOS UUID or with duplicate UUID are less than 0.05% of the hosts we manage. CONCLUSION No need to add great complexity malformed UUID hosts 0.05%. But remove the MAC issues from the solution. METHOD Remove the MAC address from vds unique id. Allow to bypass BIOS UUID with configuration. DETAILS If /etc/vdsm/vdsm.id exists at host, content is the vds unique id. If running on RHEV-H persist /etc/vdsm/vdsm.id during bootstrap or vdsm-reg. /etc/vdsm/vdsm.id is created by first engine vds unique id lookup or manually by administrator. SIDE EFFECTS If RHEV-H is reinstalled on malformed host (one with no BIOS UUID) it will be treated as a new host. RHEV-H without the complimentary vdsm fix will not be able to register if installed on BIOS that does not support UUID, as it will not generate logical UUID before registration. If BIOS contains duplicate UUID, manual intervention should apply, creating /etc/vdsm/vdsm.id manually. Change-Id: I763c7df40706a37eef53bc690294f0f84c57b374 Signed-off-by: Alon Bar-Lev <[email protected]> --- M vds_bootstrap/setup M vdsm/constants.py.in M vdsm/utils.py M vdsm_reg/deployUtil.py.in 4 files changed, 50 insertions(+), 32 deletions(-) Approvals: Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I763c7df40706a37eef53bc690294f0f84c57b374 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Burns <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
