Nir Soffer has posted comments on this change.

Change subject: coverage: Add vdsm-coverage sub package
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/49807/5/coverage/coverage.conf.in
File coverage/coverage.conf.in:

Line 1: # Vdsm coverage configuration
> What about copyright here?
We don't copyright configuration files.
Line 2: # See http://coverage.readthedocs.org/en/latest/config.html
Line 3: 
Line 4: [run]
Line 5: data_file = @VDSMRUNDIR@/vdsm.coverage


https://gerrit.ovirt.org/#/c/49807/5/coverage/vdsm.in
File coverage/vdsm.in:

Line 1: # Vdsm environment varibales
> What about copyright here?
We don't copyright configuration files.
Line 2: 
Line 3: # Enable coverage report using specified configuration


-- 
To view, visit https://gerrit.ovirt.org/49807
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95454731ca1c19e6f01417d2c26023e7c748365a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Petr Balogh <pbal...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to