Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: import netinfo modules' members directly ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/53681/1/lib/vdsm/network/configurators/ifcfg.py File lib/vdsm/network/configurators/ifcfg.py: Line 41: from vdsm import dsaversion Line 42: from vdsm import hooks Line 43: from vdsm import ipwrapper Line 44: from vdsm.netinfo import NET_PATH Line 45: from vdsm.netinfo.bonding import (BONDING_MASTERS, in a big module like this one, I find the multitude of imported names quite confusing. I prefer to import the module, and keep it as a qualifier throughout the code, to remind me where does it come from. Line 46: BONDING_MODES_NAME_TO_NUMBER, BONDING_OPT, Line 47: bondOpts, getDefaultBondingOptions, slaves) Line 48: from vdsm.netinfo.cache import ifaceUsed Line 49: from vdsm.netinfo.misc import getIfaceCfg, ipv6_supported -- To view, visit https://gerrit.ovirt.org/53681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I643d11e8c2d915097d69ede52f15f26d63f5db3f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
