Edward Haas has posted comments on this change. Change subject: net: also disable IPv6 on bridges not using it, after unified restoration ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/53683/6/vdsm/vdsm-restore-net-config File vdsm/vdsm-restore-net-config: Line 136: logging.debug('Calling setupNetworks with networks (%s) ' Line 137: 'and bond (%s).', nets, bonds) Line 138: setupNetworks(nets, bonds, {'connectivityCheck': False, Line 139: '_inRollback': True}) Line 140: if ipv6_supported(): I would prefer to see this checked in the running vs kernel check and not here. Applying it on-the-fly (detecting that this is the only change and not affecting anything else). Line 141: _restore_disable_ipv6(nets) Line 142: Line 143: Line 144: def _verify_all_devices_are_up(owned_ifcfg_files): -- To view, visit https://gerrit.ovirt.org/53683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12be9d8c99ddfeb85d6ba6093535e35b6883e963 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
