Piotr Kliczewski has posted comments on this change. Change subject: tests: Move network tests to its own folder ......................................................................
Patch Set 3: Code-Review-1 (16 comments) https://gerrit.ovirt.org/#/c/53704/3/Makefile.am File Makefile.am: Line 2: 2008-2012 Please update date https://gerrit.ovirt.org/#/c/53704/3/configure.ac File configure.ac: Line 2: 2008-2012 Please update date https://gerrit.ovirt.org/#/c/53704/3/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 2: 2013-2014 Please update date https://gerrit.ovirt.org/#/c/53704/3/tests/functional/networkTestsOVS.py File tests/functional/networkTestsOVS.py: Line 2: 2015 Please update date https://gerrit.ovirt.org/#/c/53704/3/tests/network/conf_persistence_test.py File tests/network/conf_persistence_test.py: Line 2: 2013 Please update to 2013 - 2016 https://gerrit.ovirt.org/#/c/53704/3/tests/network/conf_test.py File tests/network/conf_test.py: Line 3: 2012-2014 Please update date https://gerrit.ovirt.org/#/c/53704/3/tests/network/config_network_test.py File tests/network/config_network_test.py: Line 3: 2012-2014 Please update date https://gerrit.ovirt.org/#/c/53704/3/tests/network/iproute2_test.py File tests/network/iproute2_test.py: Line 2: 2014 Please update date https://gerrit.ovirt.org/#/c/53704/3/tests/network/ipwrapper_test.py File tests/network/ipwrapper_test.py: Line 2: 2013 Please update date https://gerrit.ovirt.org/#/c/53704/3/tests/network/models_test.py File tests/network/models_test.py: Line 3: 2013-2014 Please update date https://gerrit.ovirt.org/#/c/53704/3/tests/network/netinfo_test.py File tests/network/netinfo_test.py: Line 2: 2012 Please update date https://gerrit.ovirt.org/#/c/53704/3/tests/network/qos_test.py File tests/network/qos_test.py: Line 1: 2014 Please update date https://gerrit.ovirt.org/#/c/53704/3/tests/network/tc_filter_show.out File tests/network/tc_filter_show.out: Line 13: filter protocol all pref 49149 u32 fh 803::800 order 2048 key ht 803 bkt 0 terminal flowid ??? Line 14: match 00000000/00000000 at 0 Line 15: action order 1: mirred (Egress Mirror to device tap1) pipe Line 16: index 18 ref 1 bind 1 Line 17: Please remove trailing whitespaces Line 18: filter protocol all pref 49150 u32 Line 19: filter protocol all pref 49150 u32 fh 802: ht divisor 1 Line 20: filter protocol all pref 49150 u32 fh 802::800 order 2048 key ht 802 bkt 0 terminal flowid ??? Line 21: match 00000000/00000000 at 0 https://gerrit.ovirt.org/#/c/53704/3/tests/network/tc_test.py File tests/network/tc_test.py: Line 3: 2012-2014 Please update date https://gerrit.ovirt.org/#/c/53704/3/tests/network/unified_persistence_test.py File tests/network/unified_persistence_test.py: Line 2: 2015 Please update date https://gerrit.ovirt.org/#/c/53704/3/tests/samplingTests.py File tests/samplingTests.py: Line 2: 2014 Please update date -- To view, visit https://gerrit.ovirt.org/53704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35031fd50d0451c6321bdf8eee28127422bedafe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
