Laszlo Hornyak has posted comments on this change.
Change subject: proposed cleanup for Amador's patch
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/caps.py
Line 117: 'core':
int(cpu.getElementsByTagName('topology')[0].
Line 118:
getAttribute('cores')),
Line 119: 'thread':
int(cpu.getElementsByTagName('topology')[0].
Line 120:
getAttribute('threads'))}
Line 121: except BaseException, e:
Done
Line 122: logging.error('error calculating the topology data: %s',
e)
Line 123: # During tests/make rpm, libvirt may not be
available/configured.
Line 124: # Hack arround it.
Line 125: topology = {'numa': 1,
--
To view, visit http://gerrit.ovirt.org/8302
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I677f13e9a511bb1652dbbb84fe672714215e5aa8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Amador Pahim <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches