Edward Haas has posted comments on this change. Change subject: net: Fix dhcp reporting ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/53827/1/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 452: if net_attrs is None: Line 453: logging.debug('There is no VDSM network configured on %s.' % iface) Line 454: if not is_persistence_unified(): Line 455: cfg = getIfaceCfg(iface) Line 456: return ((family == 4 and > I would personally find this more readable as Done Line 457: cfg.get('BOOTPROTO', 'none') == 'dhcp') or Line 458: (family == 6 and Line 459: cfg.get('IPV6INIT', 'no') == 'yes' and Line 460: cfg.get('BOOTPROTO', 'none') == 'dhcp') or Line 459: no > initscripts' default for this is 'yes'. Good point. IPV6INIT defaults to 'yes', right. DHCPV6C must be explicitly set to 'yes' for DHCP to work. On the other hand, IPv6 address may be dynamically assigned using Router Advertisement (enabled @ the router), this is enabled on the client using IPV6_AUTOCONF=yes, where the default is 'yes' (but also dependent on IPV6FORWARDING). Bottom line: It's complex :) I'll sync with the logic above. -- To view, visit https://gerrit.ovirt.org/53827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7879ff488d26bc9993416b1af9635d5e882d9123 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
