Igor Lvovsky has posted comments on this change.
Change subject: Related to BZ#854151 - Fix disconnect iscsi connections.
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm/storage/storageServer.py
Line 343: sessions = iscsi.iterateIscsiSessions()
Line 344: try:
Line 345: info = iscsi.getSessionInfo(self._lastSessionId)
Line 346: except Exception:
Line 347: self.log.warning("Can't get session info,
self._lastSessionId %s", self._lastSessionId)
Can you use _lastSessionId without 'self.' in the message?
or keep it as debug
Line 348: else:
Line 349: sessions = chain(info, sessions)
Line 350:
Line 351: self.log.debug("self._target: %s", self._target)
Line 372: try:
Line 373: sid = self.getSessionInfo().id
Line 374: except OSError, e:
Line 375: if e.errno == errno.ENOENT:
Line 376: self.log.warning("Can't get iscsi session id, ENOENT:
%s", e.errno)
why %s it always ENOENT here?
Line 377: return
Line 378: self.log.warning("Cant get iscsi session id, errno: %s",
e.errno)
Line 379: raise
Line 380:
--
To view, visit http://gerrit.ovirt.org/8305
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic390cf1a63594a87ee03c010df31f68a432ebff4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
