Dan Kenigsberg has posted comments on this change.

Change subject: Store engine web CA cert in engine_web_ca.pem
......................................................................


Patch Set 3: Looks good to me, approved

(1 inline comment)

summing-up Alon and Douglas's acks.

....................................................
Commit Message
Line 13: download the SSH key, and this means that registration fails.
Line 14: 
Line 15: This patch changes deployUtil.py so that it downloadto s the 
certificate
Line 16: of the CA that signs the certificate of the engine web server to a new
Line 17: file: /etc/pki/vdsm/enginecacert.pem. This file is not touched by the
this has changed since this has been written, but I don't want to loose the 
nice acks you've got.
Line 18: VDSM start script, so that vdsm-reg can use it later to download the 
SSH
Line 19: key correctly.
Line 20: 
Line 21: Change-Id: I127bf44cbcde90f7dae26a3bd3127f3eac2ca53c


--
To view, visit http://gerrit.ovirt.org/8038
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I127bf44cbcde90f7dae26a3bd3127f3eac2ca53c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to