Nir Soffer has posted comments on this change. Change subject: gluster: Don't fail connect server when getting volume info` ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/53785/4/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 347: "servers") Line 348: return Line 349: Line 350: if self.volinfo is None: Line 351: return I think the flow is: - connect - validate - get volume info - get options - use volume info - mount using options So after this change, we will never call self.volinfo. This will fix the errors, but will also disable the entire feature of validating and adding backup servers. We should change the code so it does not matter in which order you access self.volinfo, you will get the same error in all cases. You should log once this issue. Line 352: Line 353: replicaCount = self.volinfo['replicaCount'] Line 354: if replicaCount not in self.ALLOWED_REPLICA_COUNTS: Line 355: self.log.warning("Unsupported replica count (%s) for volume %r, " -- To view, visit https://gerrit.ovirt.org/53785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
