Nir Soffer has posted comments on this change. Change subject: schema: inconsistency fixes ......................................................................
Patch Set 5: Code-Review+1 (1 comment) Storage change looks ok, waiting from acks from other subsystem maintainers. https://gerrit.ovirt.org/#/c/53460/5/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 8449: 'data': {'uuid': 'UUID', 'allocType': 'VolumeAllocation', Line 8450: 'format': 'VolumeFormat', 'disktype': 'DiskType', Line 8451: 'voltype': 'VolumeRole', 'capacity': 'uint', 'parent': 'UUID', Line 8452: 'description': 'str', 'pool': 'UUID', 'domain': 'UUID', Line 8453: 'image': 'UUID', 'ctime': 'int', 'mtime': 'uint', mtime is not optional, but the value is always 0 :-) Line 8454: 'legality': 'VolumeLegality', 'apparentsize': 'uint', Line 8455: 'truesize': 'uint', 'status': 'VolumeStatus', 'children': ['UUID']}} Line 8456: Line 8457: ## -- To view, visit https://gerrit.ovirt.org/53460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95f4f639f3d7de1179f4c77b5267134e88044fd3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches