Nir Soffer has posted comments on this change. Change subject: v2v: use new jobs infrastructure ......................................................................
Patch Set 3: (2 comments) Partial review https://gerrit.ovirt.org/#/c/52858/3/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 80 Line 81 Line 82 Line 83 Line 84 This does not comply with the schema of getJobs - there are no such statuses. I would like to avoid returning value which are not specified by the schema. If you want to have job specific state, we should add a public api to access it. Line 82 Line 83 Line 84 Line 85 Line 86 This is now "failed", so you will have to change the engine side to look for the new string. -- To view, visit https://gerrit.ovirt.org/52858 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac71559e02502580de9c2e537733ec7286682050 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
