Francesco Romani has posted comments on this change. Change subject: move logUtils to lib ......................................................................
Patch Set 2: Code-Review+1 (1 comment) nit inside, not critical however https://gerrit.ovirt.org/#/c/53889/2/vdsm.spec.in File vdsm.spec.in: Line 1100: %{python_sitelib}/%{vdsm_name}/ipwrapper.py* Line 1101: %{python_sitelib}/%{vdsm_name}/jobs.py* Line 1102: %{python_sitelib}/%{vdsm_name}/jsonrpcvdscli.py* Line 1103: %{python_sitelib}/%{vdsm_name}/kernelconfig.py* Line 1104: %{python_sitelib}/%{vdsm_name}/logUtils.py* nit: should be after libvirtconnection.py Line 1105: %{python_sitelib}/%{vdsm_name}/libvirtconnection.py* Line 1106: %{python_sitelib}/%{vdsm_name}/m2cutils.py* Line 1107: %{python_sitelib}/%{vdsm_name}/netinfo/__init__.py* Line 1108: %{python_sitelib}/%{vdsm_name}/netinfo/addresses.py* -- To view, visit https://gerrit.ovirt.org/53889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39b833ff5746db7a764ab9d9120e73a083d14365 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
