Dan Kenigsberg has posted comments on this change. Change subject: net: api: move netinfo update and save one call ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/53760/2/lib/vdsm/network/api.py File lib/vdsm/network/api.py: Line 685 Line 686 Line 687 Line 688 Line 689 how costly is this call? I would really prefer to keep _netinfo up-to-date, even though the current caller of this function does not use it. Frankly, I suspect that this change is a premature optimization that distracts us from our main goal (simplifying setupNetworks() and splitting it apart) -- To view, visit https://gerrit.ovirt.org/53760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4dd7572986ffee5a2060470d904116d04e80c97 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
